Closed
Conversation
Contributor
|
Adding |
Contributor
Author
I've changed the commit to simply replace the filename with |
Contributor
|
LGTM. I think just fix the author -- "All commits have, as the author, your name and valid email address as you would like to see them in the FreeBSD repository. Fake github.com addresses cannot be used." ~FreeBSD-src/CONTRIBUTING.md |
by default, sha256sum and sha512sum will look for any file mentioned in the CHECKSUM file, which is all of them: $ wc -l < CHECKSUM.SHA512-FreeBSD-14.1-RELEASE-amd64 10 with the current command, this will lead to 9 failures and 1 OK. the fact that you specify the filename to be checked does not seem to mean that is the *only* file that is checked. for this reason, I suggest that the filename to be checked is removed, and replaced with the flag --ignore-missing which is present in both commands on both BSD and Linux. this flag means that all files mentioned will be checked, just like before, but output will only be returned for successful checks. this assumes that the img file is in the same directory, but this was already assumed in the previous version.
Contributor
Author
|
Fixed author and email in c22c9c5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by default, sha256sum and sha512sum will look for any file mentioned in the CHECKSUM file, which is all of them:
with the current command, this will lead to 9 failures and 1 OK. the fact that you specify the filename to be checked does not seem to mean that is the only file that is checked.
for this reason, I suggest that the filename to be checked is removed, and replaced with the flag --ignore-missing which is present in both commands on both BSD and Linux.
this flag means that all files mentioned will be checked, just like before, but output will only be returned for successful checks. example:
this assumes that the img file is in the same directory, but this was already assumed in the previous version.